Skip to content

G4InfoReducer and SimpleMerge are part of larg4 #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kjplows merged 2 commits into from
Dec 17, 2025
Merged

G4InfoReducer and SimpleMerge are part of larg4 #612

kjplows merged 2 commits into from
Dec 17, 2025

Conversation

@lgarren
Copy link
Contributor

@lgarren lgarren commented Dec 4, 2025 •
edited
Loading

larg4 PRs 58 and 56 added G4InfoReducer and SimpleMerge to larg4/Core. The corresponding fcl files were added to larg4/fcl. However, larg4/Core/CMakeLists.txt was not modified to build the modules. The problem was reported in redmine issue #30201 and fixed in LArSoft/larg4#59 . This is a companion PR to remove the files from sbncode to avoid duplication.

@LauPM you may wish to comment.

@lgarren lgarren mentioned this pull request Dec 4, 2025
Merged
@FNALbuild
Copy link

FNALbuild commented Dec 4, 2025

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larg4#59

@FNALbuild
Copy link

FNALbuild commented Dec 4, 2025

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28633&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

@FNALbuild
Copy link

FNALbuild commented Dec 4, 2025

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28632&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

@FNALbuild
Copy link

FNALbuild commented Dec 4, 2025

-SBND tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/19370&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28632&builds=

@FNALbuild
Copy link

FNALbuild commented Dec 4, 2025

-ICARUS tests failed, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/13608&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28632&builds=

@FNALbuild
Copy link

FNALbuild commented Dec 4, 2025

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/13096&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28632&builds=

@FNALbuild
Copy link

FNALbuild commented Dec 4, 2025

-DUNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/20422&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28632&builds=

@lgarren
Copy link
Contributor Author

lgarren commented Dec 5, 2025

This PR is needed for larsoft v10_14_01

@kjplows kjplows self-assigned this Dec 8, 2025
@kjplows kjplows self-requested a review December 8, 2025 20:37
@kjplows
Copy link
Contributor

kjplows commented Dec 8, 2025

Hi @lgarren, thanks for highlighting this! This will be picked up with the next sbncode release.

@kjplows kjplows moved this to Testing in SBN software development Dec 8, 2025
This was referenced Dec 11, 2025
Merged
Merged
@kjplows kjplows moved this from Testing to To merge in SBN software development Dec 14, 2025
@kjplows kjplows merged commit acd7a8b into SBNSoftware:develop Dec 17, 2025
@github-project-automation github-project-automation bot moved this from To merge to Done in SBN software development Dec 17, 2025
@kjplows kjplows moved this from Done to Recently done in SBN software development Dec 17, 2025
@kjplows kjplows moved this from Recently done to Done in SBN software development Jan 16, 2026
@kjplows kjplows moved this from Done to 2025 PRs in SBN software development Jan 16, 2026
@kjplows kjplows added this to the v10_14_02 milestone Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kjplows kjplows kjplows approved these changes

Assignees

@kjplows kjplows

Labels

maintenance

Projects

PR archaeology
Status: Done
SBN software development
Status: 2025 PRs

Milestone

v10_14_02

Development

Successfully merging this pull request may close these issues.

3 participants

@lgarren @FNALbuild @kjplows